Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix branch syntax stripping #8

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Conversation

gabyx
Copy link
Owner

@gabyx gabyx commented Feb 5, 2021

  • Added unit tests.

- Added unit tests.
@gabyx gabyx requested review from rycus86 and removed request for rycus86 February 5, 2021 22:01
@gabyx gabyx merged commit 7355c73 into main Feb 6, 2021
gabyx added a commit that referenced this pull request Feb 8, 2021
Fix branch syntax stripping

Before any (last) `@branch` is stripped, one needs to know from what
part:

- Normal url:  trim off from `url.Path` .
- SCP syntax: trim off from `address` .
- Anything else: trim off from `@branch`.
@gabyx gabyx deleted the bugfix/fix-branch-syntax-stripping branch February 10, 2021 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant