Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Icon view watched and unwatched difference for episodes #21

Closed
MaikoHermans opened this issue May 21, 2016 · 13 comments
Closed

Icon view watched and unwatched difference for episodes #21

MaikoHermans opened this issue May 21, 2016 · 13 comments
Labels

Comments

@MaikoHermans
Copy link

It's currently not clear which episode is already watched and which is unwatched when using the wall view. Maybe put a small dot in a corner to indicate that it's new/unwatched.

@gade01
Copy link
Owner

gade01 commented May 21, 2016

I'm not sure I'm following you. A screenshot is appreciated.

Wall view for tv shows have watched overlays in the bottom right corner.
When a tv show is watched, a check mark will be visible. When a tv show is unwatched, you'll see the number of unwatched episodes in a circle.

@MaikoHermans
Copy link
Author

MaikoHermans commented May 22, 2016

Sorry I didnt descripe it properly because you're right about that.

What I should have said is when the episode view is set to icons you can't tell which episode is watched and which is unwatched. I'll grab a screenshot too and edit this post.

Again my bad for describing it wrong my apologies

EDIT:
image

Looking at the icons I can't tell which one is unwatched and which isn't. Like it says in the left bottom corner. one of the episodes in this season is unwatched but which one is something you would have to know. When switching to any of the other views you are able to tell tho. Just the icon view doesn't hold any info on this as far as I'm able to tell atleast

@gade01
Copy link
Owner

gade01 commented May 22, 2016

You are absolutely right. Thanks for the detailed description - and very well spotted ;)

I'll fix this as soon as possible.

EDIT: I edited the title to Icon view.

@gade01 gade01 changed the title Wall view watched and unwatched difference Icon view watched and unwatched difference for episodes May 22, 2016
@MaikoHermans
Copy link
Author

No problem. I tried figuring out where this could be located myself but it's late and I never messed with kodi skins so that was asking a lil much of myself at this point lol

@gade01 gade01 added the Bug label May 22, 2016
@gade01
Copy link
Owner

gade01 commented May 22, 2016

Haha, it's located in ViewsCommon.xml :)

Fixed for Krypton: 44cabee
Fixed for Jarvis: 79d3bfb
Fixed for Isengard: 4ed88f5

Thanks again!

@gade01 gade01 closed this as completed May 22, 2016
@MaikoHermans
Copy link
Author

I see the changes in the commit. I'm gonna take a look at it when I get behind a pc and play with it a lil. I find it very interesting.

If you don't mind me asking. Are your commits synced with the kodi add on repository? I'm guessing they are just want to be sure that's how it works. Also if I'm correct the skin is 720p to make it 1080p ready what would be needed exactly? The images need upgrades? This is just me wondering how it all works.
I understand if you don't have the time to respond to all those questions haha.

@gade01
Copy link
Owner

gade01 commented May 22, 2016

Cool, let me know if you have any questions.

New versions are pushed to the official Kodi add-on repo once a month or so.
Development versions are pushed to my development repo once or twice a week.
Read here how to install: http://kodi.wiki/view/Add-on:Rapier#Development_version_.2F_Gade.27s_Add-on_Repository

To make the skin 1080p ready would require a ton of work. There are tools to make it easier and automate certain calculations, but everything still needs to be checked and adjusted. Some images will probably need an update while others won't.

@MaikoHermans
Copy link
Author

Alright quick question in the string parsing are you allowed to do something like #3113-1 or #3113.1 or anything like that? or is plain text allowed only?

@gade01
Copy link
Owner

gade01 commented May 23, 2016

For labels?

@MaikoHermans
Copy link
Author

yea, to refer to the strings.

btw is there possible a better way to communicate question to not clutter your repository.

@gade01
Copy link
Owner

gade01 commented May 23, 2016

http://kodi.wiki/view/Label_Parsing

I recommend using the forums. This way other people can benefit from the answers too: http://forum.kodi.tv/forumdisplay.php?fid=120

@MaikoHermans
Copy link
Author

I found that link I was just wondering if it would accept dashes in a number as well.
I'll continue on the forum from here on out. Thanks!

@gade01
Copy link
Owner

gade01 commented May 23, 2016

Hmmm... I don't know - haven't tried it. Try it out!

See you at the forums ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants