Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp on Windows #271

Merged
merged 1 commit into from
Dec 29, 2014
Merged

Fix gulp on Windows #271

merged 1 commit into from
Dec 29, 2014

Conversation

gmist
Copy link
Contributor

@gmist gmist commented Dec 22, 2014

I tested it on Windows XP and everything seems to be working, but unfortunately I'm unable to check it on other versions of Windows (Vista/7/8/10).
screen shot 2014-12-22 at 8 05 07 pm

@davidstackio
Copy link
Contributor

If it helps, I was able to install and run run.py -s locally on Windows 7 (v1.8)

@lipis
Copy link
Member

lipis commented Dec 23, 2014

@dhstack You should try to run gulp with this PR.. that's what is all about

@davidstackio
Copy link
Contributor

So I cloned gmist:fix_gulp_win and ran run.py -s and got this error on Windows 7:

image

@davidstackio
Copy link
Contributor

I think it has to do with the spaces in the directory path (Program Files). Using quotes could fix it: https://stackoverflow.com/questions/6376113/spaces-problem-in-cmd

I thought that python's os module took care of all of this though.

@davidstackio
Copy link
Contributor

Also, as you requested, I ran gulp and got this:

image

@gmist
Copy link
Contributor Author

gmist commented Dec 23, 2014

@dhstack thank you. I fixed (I hope) problem with spaces in path, please try it again. For gulp you need to install gulp globally.

@davidstackio
Copy link
Contributor

@gmist Got gulp installed globally - thanks.

Still wasn't working. This did the trick though:
'"%s"' % os.path.join(find_gae_path(), 'dev_appserver.py'),

(notice the extra ' quotes)

@davidstackio
Copy link
Contributor

@gmist This is an aside, and due to me still learning the ins an outs of github, but how could I have pushed that change directly?

@gmist
Copy link
Contributor Author

gmist commented Dec 23, 2014

`'"%s"'`` +1 sure that's what I wanted to do :)

"could I have pushed that change directly?"
You can push code directly only in your repositories or in an organization repository if you have write permissions. Also you can create pull request for any public repository.

@davidstackio
Copy link
Contributor

@gmist Thanks for the links.

So could I have created a pull request on this? Or because it already is a pull request, the way I did it -propose my change in a comment - was best?

@gmist
Copy link
Contributor Author

gmist commented Dec 24, 2014

I have already fix it (5a59511), therefore PR do not needed. I think that for small remarks/issues is better to use comments for a specific line of code.

@lipis
Copy link
Member

lipis commented Dec 27, 2014

Yes.. commenting lines is much better for PRs instead of a new PR.. I'm back from vacations next week and will follow up :)

GAE_PATH = gae_path
else:
gae_path = os.path.join(gae_path, '..', 'platform', 'google_appengine')
if os.path.exists:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

os.path.exists(gae_path)

@lipis lipis added the bug label Dec 28, 2014
@lipis
Copy link
Member

lipis commented Dec 29, 2014

This one looks ready.. can anyone verify if works ok on different Windows to verify? (@gmist will you squash it..?)

lipis added a commit that referenced this pull request Dec 29, 2014
@lipis lipis merged commit 907cc9d into gae-init:master Dec 29, 2014
@gmist gmist deleted the fix_gulp_win branch June 16, 2015 15:01
rbubley pushed a commit to rbubley/gae-init that referenced this pull request Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants