-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix gulp on Windows #271
Fix gulp on Windows #271
Conversation
If it helps, I was able to install and run |
@dhstack You should try to run |
I think it has to do with the spaces in the directory path (Program Files). Using quotes could fix it: https://stackoverflow.com/questions/6376113/spaces-problem-in-cmd I thought that python's os module took care of all of this though. |
@dhstack thank you. I fixed (I hope) problem with spaces in path, please try it again. For gulp you need to install gulp globally. |
@gmist Got gulp installed globally - thanks. Still wasn't working. This did the trick though: (notice the extra ' quotes) |
@gmist This is an aside, and due to me still learning the ins an outs of github, but how could I have pushed that change directly? |
`'"%s"'`` +1 sure that's what I wanted to do :) "could I have pushed that change directly?" |
@gmist Thanks for the links. So could I have created a pull request on this? Or because it already is a pull request, the way I did it -propose my change in a comment - was best? |
I have already fix it (5a59511), therefore PR do not needed. I think that for small remarks/issues is better to use comments for a specific line of code. |
Yes.. commenting lines is much better for PRs instead of a new PR.. I'm back from vacations next week and will follow up :) |
GAE_PATH = gae_path | ||
else: | ||
gae_path = os.path.join(gae_path, '..', 'platform', 'google_appengine') | ||
if os.path.exists: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
os.path.exists(gae_path)
This one looks ready.. can anyone verify if works ok on different Windows to verify? (@gmist will you squash it..?) |
Fix gulp on Windows
I tested it on Windows XP and everything seems to be working, but unfortunately I'm unable to check it on other versions of Windows (Vista/7/8/10).