This repository has been archived by the owner on Apr 9, 2020. It is now read-only.
Add React.PureComponent to the list of default super classes #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaearon
reviewed
Sep 11, 2017
| @@ -1,8 +1,6 @@ | |||
| export default class Foo extends React.Component {} | |||
| export default class extends React.Component {} | |||
There was a problem hiding this comment.
By the current spec only one default export can exist per module (I guess this has changed since this package was created). Babel now complains about this (maybe because the dependencies in this repo are not locked since it does not use yarn).
|
Please ping me in person or via workplace messenger next time :-) I don't actively watch this repository. |
|
3.0.0 |
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Sep 14, 2017
Summary: babel-plugin-react-transform@3 includes support for HMR on `React.PureComponent`: gaearon/babel-plugin-react-transform#106 Reviewed By: davidaurelio Differential Revision: D5814322 fbshipit-source-id: 36e83ffa00f9d4ff079665aec1e8341725811a8e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the HMR transform to work on components that extend
React.PureComponent