Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webpack says nothing changed even when I added a line #20

Closed
neerajsingh0101 opened this issue May 14, 2015 · 4 comments
Closed

webpack says nothing changed even when I added a line #20

neerajsingh0101 opened this issue May 14, 2015 · 4 comments

Comments

@neerajsingh0101
Copy link

http://take.ms/0kfVz

I am using mac.

Is this because React should return only one element. If that is the case then ideally I should get an error in console.

I see the error in terminal. Just wanted to know if it is possible to indicate someway that "hey something went wrong. Look at log in terminal.".

@neerajsingh0101
Copy link
Author

If I use https://github.com/FrontendMasters/2015-02-13-React setup by @ryanflorence then I do get error message which is nice.

http://take.ms/7gCma

@gaearon
Copy link
Owner

gaearon commented May 29, 2015

This is because of NoErrorsPlugin in the config. You can remove it, but then HMR will break if you misspell an import. I'm not sure which is worse..

I'd like some kind of a middle solution here. Currently filed as webpack/webpack#1105, so please track that issue if you're interested in the solution when/if it arrives.

@gaearon gaearon closed this as completed May 29, 2015
@gaearon
Copy link
Owner

gaearon commented Aug 28, 2015

Remove NoErrorsPlugin and use React Hot Loader >= 1.3.0.

@neerajsingh0101
Copy link
Author

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants