Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with not injecting changes #418

Closed
th3fallen opened this issue Nov 17, 2016 · 2 comments
Closed

Problems with not injecting changes #418

th3fallen opened this issue Nov 17, 2016 · 2 comments

Comments

@th3fallen
Copy link

You requested a issue for this so here i am :P

Description

What you are reporting:
Hot-loader v3 reports changes but forces to reload

Expected behavior

What you think should happen:
should behave like v1 and inject the changes

Actual behavior

What actually happens:

Environment

React Hot Loader version: 3.0.0-beta.6

Run these commands in the project folder and fill in their results:

  1. node -v: v7.1.0
  2. npm -v: 4.0.2

Then, specify:

  1. Operating system: 10.12.2 beta (16C48b)
  2. Browser and version: Chrome Latest

Reproducible Demo

i demo is not possible due to scale but here are the relevant files
https://gist.github.com/th3fallen/bba636b4bf1045188aa3a02a04b27a4b

@calesce
Copy link
Collaborator

calesce commented Nov 18, 2016

Are you using a separate .babelrc? I think babel-loader needs plugins to be defined as query.plugins. We have problems when not using ES2015 preset (see #313), so maybe that's what your issue is.

Also, instead of re-importing Main.js, you'll need to re-import routes, since that module is the "entry point" to other component modules. For React Router stuff see #249.

@calesce
Copy link
Collaborator

calesce commented Nov 23, 2016

Hey, I'm closing this out due to lack of response, and I gave you a few potential solutions. Let me know if those don't work.

@calesce calesce closed this as completed Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants