fix: handle async loading of patch #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #739 +/- ##
=========================================
+ Coverage 75.34% 75.6% +0.26%
=========================================
Files 12 13 +1
Lines 434 451 +17
Branches 99 136 +37
=========================================
+ Hits 327 341 +14
- Misses 90 92 +2
- Partials 17 18 +1
Continue to review full report at Codecov.
|
|
Hey! I've simplified babel. Look like it works well. |
theKashey
force-pushed
the
handle-async-loading
branch
from
e47f270
to
906646d
Compare
gregberge
commented
Dec 28, 2017
| @@ -1 +1,4 @@ | |||
| /* noop */ | |||
| module.exports = { | |||
| default: false, | |||
.eslintrc.js
Outdated
| allow: [ | ||
| '__REACT_HOT_LOADER__', | ||
| '__standin_getCurrent', | ||
| '__registeredComponents', |
gregberge
commented
Dec 28, 2017
| @@ -31,10 +31,11 @@ module.exports = function plugin(args) { | |||
| const buildTagger = template( | |||
| ` | |||
| var UNUSED = (function () { | |||
| if (typeof __REACT_HOT_LOADER__ === 'undefined') { | |||
| return; | |||
| var __REACT_HOT_LOADER__ = global.__REACT_HOT_LOADER__ || require('react-hot-loader/patch').default; | |||
There was a problem hiding this comment.
Global does not work in browser.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #738