fix: Mark opaque type identifiers as defined with define-flow-type (#283

)

* fix: Mark opaque type identifiers as defined with define-flow-type

* docs: Regenerate documentation with npm run documentation

There was diff unrelated to opaque type fix, so I didn't commit them

README.md

@@ -252,6 +252,9 @@ var a: AType<BType>
 type A = AType
 // Additional rules: {"no-undef":2}
 
+opaque type A = AType
+// Additional rules: {"no-undef":2}
+
 function f(a: AType) {}
 // Additional rules: {"no-undef":2}
 
@@ -306,6 +309,9 @@ var a: AType<BType>
 type A = AType
 // Additional rules: {"no-undef":2,"no-use-before-define":[2,"nofunc"]}
 
+opaque type A = AType
+// Additional rules: {"no-undef":2,"no-use-before-define":[2,"nofunc"]}
+
 function f(a: AType) {}
 // Additional rules: {"no-undef":2,"no-use-before-define":[2,"nofunc"]}
 

src/rules/defineFlowType.js

@@ -58,6 +58,11 @@ const create = (context) => {
     InterfaceDeclaration (node) {
       makeDefined(node.id);
     },
+    OpaqueType (node) {
+      if (node.id.type === 'Identifier') {
+        makeDefined(node.id);
+      }
+    },
     Program () {
       globalScope = context.getScope();
     },

tests/rules/assertions/defineFlowType.js

@@ -42,6 +42,14 @@ const VALID_WITH_DEFINE_FLOW_TYPE = [
       '\'A\' is not defined.'
     ]
   },
+  {
+    code: 'opaque type A = AType',
+    errors: [
+      // Complaining about 'A' not being defined might be an upstream bug
+      '\'A\' is not defined.',
+      '\'AType\' is not defined.'
+    ]
+  },
   {
     code: 'function f(a: AType) {}',
     errors: [
@@ -166,6 +174,8 @@ const ALWAYS_VALID = [
   'var a: Array',
   'var a: Array<string>',
   'type A = Array',
+  // This complains about 'A' not being defined. It might be an upstream bug
+  // 'opaque type A = Array',
   'function f(a: string) {}',
   'function f(a): string {}',
   'class C { a: string }',