fix: fix async generator bug (fixes #387)

fix #386
gajus · Feb 15, 2019 · 5adb546 · 5adb546
1 parent 842e228
commit 5adb546
Show file tree

Hide file tree

Showing 3 changed files with 7,428 additions and 1 deletion.
diff --git a/src/rules/requireReturnType.js b/src/rules/requireReturnType.js
@@ -109,7 +109,7 @@ const create = (context) => {
 
     const isArrow = functionNode.type === 'ArrowFunctionExpression';
     const isArrowFunctionExpression = functionNode.expression;
-    const isFunctionReturnUndefined = !isArrowFunctionExpression && !(functionNode.generator && !functionNode.async) && (!targetNode.returnStatementNode || isUndefinedReturnType(targetNode.returnStatementNode));
+    const isFunctionReturnUndefined = !isArrowFunctionExpression && !functionNode.generator && (!targetNode.returnStatementNode || isUndefinedReturnType(targetNode.returnStatementNode));
     const isReturnTypeAnnotationUndefined = getIsReturnTypeAnnotationUndefined(targetNode);
 
     if (skipArrows === 'expressionsOnly' && isArrowFunctionExpression || skipArrows === true && isArrow || shouldFilterNode(functionNode)) {

diff --git a/tests/rules/assertions/requireReturnType.js b/tests/rules/assertions/requireReturnType.js
@@ -361,6 +361,34 @@ export default {
           ]
         }
       ]
+    },
+    {
+      code: 'function * foo() { yield 2; }',
+      errors: [
+        {
+          message: 'Missing return type annotation.'
+        }
+      ],
+      options: [
+        'always',
+        {
+          annotateUndefined: 'always'
+        }
+      ]
+    },
+    {
+      code: 'async function * foo() { yield 2; }',
+      errors: [
+        {
+          message: 'Missing return type annotation.'
+        }
+      ],
+      options: [
+        'always',
+        {
+          annotateUndefined: 'always'
+        }
+      ]
     }
   ],
   misconfigured: [
@@ -860,6 +888,24 @@ export default {
           ]
         }
       ]
+    },
+    {
+      code: 'function * foo(): Iterable<number> { yield 2; }',
+      options: [
+        'always',
+        {
+          annotateUndefined: 'always'
+        }
+      ]
+    },
+    {
+      code: 'async function * foo(): AsyncIterable<number> { yield 2; }',
+      options: [
+        'always',
+        {
+          annotateUndefined: 'always'
+        }
+      ]
     }
   ]
 };