Don't crash when encountering unparameterized Arrays #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While these are disallowed in Flow, `typeof Array` is a valid type, which could trigger this. Rather than try to enumerate other possible cases, I simply check to make sure we don't crash when we hit them.
gajus
reviewed
May 7, 2019
| @@ -128,6 +128,16 @@ export default { | |||
| onlyFilesWithFlowAnnotation: true | |||
| } | |||
| } | |||
| }, | |||
|
|
|||
| // While this isn't valid flow, we shouldn't disallow it. | |||
There was a problem hiding this comment.
What is the use case for this if it isn't valid Flow?
There was a problem hiding this comment.
Mostly just a sanity check to check that the code won't break. I'm not attached to it at all.
|
🎉 This PR is included in version 3.8.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
kangax
pushed a commit
to kangax/eslint-plugin-flowtype
that referenced
this pull request
May 17, 2019
While these are disallowed in Flow, `typeof Array` is a valid type, which could trigger this. Rather than try to enumerate other possible cases, I simply check to make sure we don't crash when we hit them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these are disallowed in Flow,
typeof Arrayis a valid type,which could trigger this.
Rather than try to enumerate other possible cases, I simply check to
make sure we don't crash when we hit them.