feat: add require-inexact-type rule #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 3.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Hi @goodmind! I tried this new lint rule on our monorepo and seems like it reports few false positives. For example, have a look at this file: // @flow strict
export interface ILogger {
log(...message: $ReadOnlyArray<string>): void;
warn(...message: $ReadOnlyArray<string>): void;
error(...message: $ReadOnlyArray<string>): void;
}It reports the following error: It doesn't sound right (fails for basically every interface). Is it a bug or problem in our code? I see this case is not covered in your tests and I am not sure how should I fix it. Thanks for checking it. |
|
@mrtnzlml fixed |
adeira-github-bot
pushed a commit
to kiwicom/eslint-config-kiwicom
that referenced
this pull request
Jun 10, 2019
I had to wait a little bit because of this issue: gajus/eslint-plugin-flowtype#408 (comment) (fixed here: gajus/eslint-plugin-flowtype#409). Implicit inexact objects are now officially disabled in Universe. kiwicom-source-id: 9eda5b44be7928d6b4ff505b5e447b8c75dbda1b
adeira-github-bot
pushed a commit
to kiwicom/relay
that referenced
this pull request
Jun 10, 2019
I had to wait a little bit because of this issue: gajus/eslint-plugin-flowtype#408 (comment) (fixed here: gajus/eslint-plugin-flowtype#409). Implicit inexact objects are now officially disabled in Universe. kiwicom-source-id: 9eda5b44be7928d6b4ff505b5e447b8c75dbda1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Duplicate of same lint in new Flow version
This syntax exists from Flow v0.84