fix(check-access) ensures rule is still checked when a private ta…

…g is present despite even a `true` `ignorePrivate` setting.

Also adds tests for `ignorePrivate` in another `iterateAllJsdocs` rule (`check-alignment`).

.README/README.md

@@ -111,7 +111,9 @@ supplied as the second argument in an array after the error level.
 ### Allow `@private` to disable rules for that comment block
 
 - `settings.jsdoc.ignorePrivate` - Disables all rules for the comment block
-  on which a `@private` tag occurs. Defaults to `false`.
+  on which a `@private` tag occurs. Defaults to
+  `false`. Note: This has no effect with the rule `check-access` (whose
+  purpose is to check access modifiers).
 
 ### Mode
 

README.md

@@ -157,7 +157,9 @@ supplied as the second argument in an array after the error level.
 ### Allow <code>@private</code> to disable rules for that comment block
 
 - `settings.jsdoc.ignorePrivate` - Disables all rules for the comment block
-  on which a `@private` tag occurs. Defaults to `false`.
+  on which a `@private` tag occurs. Defaults to
+  `false`. Note: This has no effect with the rule `check-access` (whose
+  purpose is to check access modifiers).
 
 <a name="eslint-plugin-jsdoc-settings-mode"></a>
 ### Mode
@@ -406,6 +408,15 @@ function quux (foo) {
 }
 // Message: Missing valid JSDoc @access level.
 
+/**
+ * @access foo
+ */
+function quux (foo) {
+
+}
+// Settings: {"jsdoc":{"ignorePrivate":true}}
+// Message: Missing valid JSDoc @access level.
+
 /**
  * @accessLevel foo
  */
@@ -450,6 +461,16 @@ function quux (foo) {
 }
 // Message: At most one access-control tag may be present on a jsdoc block.
 
+/**
+ * @access public
+ * @access private
+ */
+function quux (foo) {
+
+}
+// Settings: {"jsdoc":{"ignorePrivate":true}}
+// Message: At most one access-control tag may be present on a jsdoc block.
+
 /**
  * @public
  * @private
@@ -459,6 +480,16 @@ function quux (foo) {
 }
 // Message: At most one access-control tag may be present on a jsdoc block.
 
+/**
+ * @public
+ * @private
+ */
+function quux (foo) {
+
+}
+// Settings: {"jsdoc":{"ignorePrivate":true}}
+// Message: At most one access-control tag may be present on a jsdoc block.
+
 /**
  * @public
  * @public
@@ -507,6 +538,14 @@ class MyClass {
 function quux (foo) {
 
 }
+
+/**
+ * @private
+ */
+function quux (foo) {
+
+}
+// Settings: {"jsdoc":{"ignorePrivate":true}}
 ````
 
 
@@ -631,6 +670,15 @@ function quux (foo) {
   *    So this is unchecked.
  */
 function quux (foo) {}
+
+/**
+  * @param {Number} foo
+  * @private
+ */
+function quux (foo) {
+  // with spaces
+}
+// Settings: {"jsdoc":{"ignorePrivate":true}}
 ````
 
 

src/iterateJsdoc.js

@@ -428,6 +428,7 @@ const iterate = (
 
   if (
     settings.ignorePrivate &&
+    !ruleConfig.checkPrivate &&
     utils.hasTag('private')
   ) {
     return;
@@ -529,10 +530,7 @@ export default function iterateJsdoc (iterator, ruleConfig) {
   }
 
   if (ruleConfig.iterateAllJsdocs) {
-    return iterateAllJsdocs(iterator, {
-      meta: ruleConfig.meta,
-      noTrim: ruleConfig.noTrim,
-    });
+    return iterateAllJsdocs(iterator, ruleConfig);
   }
 
   return {

src/rules/checkAccess.js

@@ -32,6 +32,7 @@ export default iterateJsdoc(({
     );
   }
 }, {
+  checkPrivate: true,
   iterateAllJsdocs: true,
   meta: {
     type: 'suggestion',

test/rules/assertions/checkAccess.js

@@ -16,6 +16,27 @@ export default {
         },
       ],
     },
+    {
+      code: `
+          /**
+           * @access foo
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          line: 3,
+          message: 'Missing valid JSDoc @access level.',
+        },
+      ],
+      settings: {
+        jsdoc: {
+          ignorePrivate: true,
+        },
+      },
+    },
     {
       code: `
           /**
@@ -110,6 +131,43 @@ export default {
         },
       ],
     },
+    {
+      code: `
+          /**
+           * @access public
+           * @access private
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'At most one access-control tag may be present on a jsdoc block.',
+        },
+      ],
+      settings: {
+        jsdoc: {
+          ignorePrivate: true,
+        },
+      },
+    },
+    {
+      code: `
+          /**
+           * @public
+           * @private
+           */
+          function quux (foo) {
+
+          }
+      `,
+      errors: [
+        {
+          message: 'At most one access-control tag may be present on a jsdoc block.',
+        },
+      ],
+    },
     {
       code: `
           /**
@@ -125,6 +183,11 @@ export default {
           message: 'At most one access-control tag may be present on a jsdoc block.',
         },
       ],
+      settings: {
+        jsdoc: {
+          ignorePrivate: true,
+        },
+      },
     },
     {
       code: `
@@ -202,5 +265,20 @@ export default {
           }
       `,
     },
+    {
+      code: `
+          /**
+           * @private
+           */
+          function quux (foo) {
+
+          }
+      `,
+      settings: {
+        jsdoc: {
+          ignorePrivate: true,
+        },
+      },
+    },
   ],
 };

test/rules/assertions/checkAlignment.js

@@ -260,5 +260,21 @@ function quux (foo) {
         function quux (foo) {}
       `,
     },
+    {
+      code: `
+        /**
+          * @param {Number} foo
+          * @private
+         */
+        function quux (foo) {
+          // with spaces
+        }
+      `,
+      settings: {
+        jsdoc: {
+          ignorePrivate: true,
+        },
+      },
+    },
   ],
 };