fix(require-return-checks): check return statements prior to last l…

…ine; fixes #935
gajus · Nov 24, 2022 · 65e927b · 65e927b
1 parent 124d327
commit 65e927b
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 1 deletion.
diff --git a/README.md b/README.md
@@ -18392,6 +18392,17 @@ const f =
   () => {
     return function () {};
   };
+
+/**
+ * Description.
+ *
+ * @returns Result.
+ */
+export function f(): string {
+  return "";
+
+  interface I {}
+}
 ````
 
 

diff --git a/src/utils/hasReturnValue.js b/src/utils/hasReturnValue.js
@@ -139,7 +139,9 @@ const allBrancheshaveReturnValues = (node, promFilter) => {
   case 'FunctionDeclaration':
   case 'ArrowFunctionExpression': {
     return node.expression && (!isNewPromiseExpression(node.body) || !isVoidPromise(node.body)) ||
-      allBrancheshaveReturnValues(node.body, promFilter);
+      allBrancheshaveReturnValues(node.body, promFilter) || node.body.body.some((nde) => {
+      return nde.type === 'ReturnStatement';
+    });
   }
 
   case 'BlockStatement': {

diff --git a/test/rules/assertions/requireReturnsCheck.js b/test/rules/assertions/requireReturnsCheck.js
@@ -1490,5 +1490,20 @@ export default {
         };
       `,
     },
+    {
+      code: `
+      /**
+       * Description.
+       *
+       * @returns Result.
+       */
+      export function f(): string {
+        return "";
+
+        interface I {}
+      }
+      `,
+      parser: require.resolve('@typescript-eslint/parser'),
+    },
   ],
 };