Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

README should not encourage using toJS() #1

Closed
aaronjensen opened this issue Aug 10, 2015 · 3 comments
Closed

README should not encourage using toJS() #1

aaronjensen opened this issue Aug 10, 2015 · 3 comments

Comments

@aaronjensen
Copy link

toJS() is not memoized, so it won't work with PureRenderMixin.

It is slow(er than not using it) and it nullifies much of benefit of using immutable.js since it's going to be doing allocs every time state changes.
@gajus
Copy link
Owner

gajus commented Aug 10, 2015

The picture you have shared does not load. Please re-upload it.

@gajus
Copy link
Owner

gajus commented Aug 10, 2015

@aaronjensen Incorporated your feedback. https://github.com/gajus/redux-immutable#unpacking-immutable-state

@gajus gajus closed this as completed Aug 10, 2015
@aaronjensen
Copy link
Author

Looks good. Sorry about the picture, i'll try again (but it looks like you got the gist any way):

js bin - js bin 2015-08-10 00-09-18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@aaronjensen @gajus