chore(clippy): make clippy happy (#2727)

gakonst · Feb 3, 2024 · 79cdcf5 · 79cdcf5
1 parent 4c119e9
commit 79cdcf5
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/ethers-providers/src/rpc/transports/common.rs b/ethers-providers/src/rpc/transports/common.rs
@@ -117,6 +117,7 @@ impl<'de: 'a, 'a> Deserialize<'de> for Response<'a> {
     where
         D: serde::Deserializer<'de>,
     {
+        #[allow(dead_code)]
         struct ResponseVisitor<'a>(&'a ());
         impl<'de: 'a, 'a> Visitor<'de> for ResponseVisitor<'a> {
             type Value = Response<'a>;

diff --git a/ethers-signers/src/aws/mod.rs b/ethers-signers/src/aws/mod.rs
@@ -223,6 +223,7 @@ impl super::Signer for AwsSigner {
     type Error = AwsSignerError;
 
     #[instrument(err, skip(message))]
+    #[allow(clippy::blocks_in_conditions)]
     async fn sign_message<S: Send + Sync + AsRef<[u8]>>(
         &self,
         message: S,
@@ -236,6 +237,7 @@ impl super::Signer for AwsSigner {
     }
 
     #[instrument(err)]
+    #[allow(clippy::blocks_in_conditions)]
     async fn sign_transaction(&self, tx: &TypedTransaction) -> Result<EthSig, Self::Error> {
         let mut tx_with_chain = tx.clone();
         let chain_id = tx_with_chain.chain_id().map(|id| id.as_u64()).unwrap_or(self.chain_id);

diff --git a/ethers-solc/src/remappings.rs b/ethers-solc/src/remappings.rs
@@ -840,7 +840,7 @@ mod tests {
 
     // <https://doc.rust-lang.org/rust-by-example/std_misc/fs.html>
     fn touch(path: &std::path::Path) -> std::io::Result<()> {
-        match std::fs::OpenOptions::new().create(true).write(true).open(path) {
+        match std::fs::OpenOptions::new().create(true).append(true).open(path) {
             Ok(_) => Ok(()),
             Err(e) => Err(e),
         }