New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EIP-2930 / EIP-2718 / EIP-1559 #265
Comments
Preliminary work: https://github.com/gakonst/ethers-rs/tree/feat/typed-transactions |
Nice. Will need this for EIP-1559. |
Yes, adding this ASAP this or the next week. |
Hey @gakonst can you assign me to this, I'll like to work on it |
How's the "typed-transactions" branch? Do we have an ETA here? I'm not trying to push here, just thinking that if it's not quite ready before the next hard fork, I'll have to hack some dirty stuff by myself then. |
I haven't been able to work on it more yet..Will try to get an update. |
Thank you @gakonst Take your time. I did a quick look, the most offending part is the middleware layer. I guess the gas price policies in middleware layer don't quite apply to new EIP1559. similar to web3.py's doc here: https://github.com/ethereum/web3.py/blob/master/docs/gas_price.rst |
Is your feature request related to a problem? Please describe.
Implement the following EIPs:
Describe the solution you'd like
I think switching to a union/enum type for transactions and implementing a Serde serializer to use the enum's index as the EIP-2718
type
could be sufficient for 2718. Then, for 2930, we'd just add a new type that implements access lists. It could probably be something likestruct Transaction2930 { tx: Transaction, accessList: AccessList }
and have it serialize to a flattened format.Additional context
Implementation in ethers-js: ethers-io/ethers.js@c47d2eb
Hardhat: https://github.com/nomiclabs/hardhat/pull/1379/files
ethereumjs-monorepo: https://github.com/ethereumjs/ethereumjs-monorepo/pulls?q=is%3Apr+is%3Aclosed+2930
The text was updated successfully, but these errors were encountered: