feat: eip2930/1559 response type adjustments (part 1) #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
changed the title
gakonst
changed the title
guanqun
reviewed
Aug 2, 2021
| use serde::{Deserialize, Serialize}; | ||
|
|
||
| /// Access list | ||
| #[derive(Debug, Default, Clone, PartialEq, Serialize, Deserialize, RlpEncodable)] |
There was a problem hiding this comment.
I think I hit one bug here, RlpEncodable should be RlpEncodableWrapper. unless you're using .0 to do the rlp encoding, otherwise you got an extra "[]".
mattsse
approved these changes
Aug 2, 2021
onbjerg
reviewed
Aug 6, 2021
| pub gateway_fee: Option<U256>, | ||
|
|
||
| // EIP2718 | ||
| /// Transaction type, Some(1) for AccessList transaction, None for Legacy |
There was a problem hiding this comment.
Should probably also mention that Some(2) is EIP1559
3 tasks
meetmangukiya
pushed a commit
to meetmangukiya/ethers-rs
that referenced
this pull request
Mar 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base_fee_per_gastoBlockaccess_list,transaction_type,max_priority_fee_per_gas,max_fee_per_gastoTransactiontransaction_type,effective_gas_pricetoTransactionReceiptSignerMiddleware::sign_transactionnow returns an rlp encoded signed transaction instead of aTransactionMiddleware::send_raw_transactionnow receives a signed rlp transaction instead of aTransaction