feat(ethers-contract): typed txs (part 4) #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
changed the title
gakonst
force-pushed
the
feat/typed-txs-contracts
branch
from
8ff8e72
to
1d4230f
Compare
|
Thanks for the amazing work on this library! |
|
I'll be working on the final bits to merge these PRs -today-, there's currently a serialization bug (along with some extra tests against testnets) |
gakonst
force-pushed
the
feat/typed-txs-rpc
branch
from
81eb23d
to
8b320ef
Compare
This may break any tests which use Ganache, since it only supports legacy transactions. We should replace Ganache with hardhat where possible
This is useful for chains like Celo that do not support the Typed Envelope
gakonst
force-pushed
the
feat/typed-txs-contracts
branch
from
31f05e6
to
a629f7b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypedTransactioninside theContractCallobjectlegacyfeature flag is on), allows falling back to legacy ones via thelegacyhelper functionlegacy()because ganache does not support Berlin or London yet (?!?)