Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(abigen): contract names can be reserve words #1498

Merged
merged 7 commits into from
Jul 24, 2022

Conversation

clifton
Copy link
Contributor

@clifton clifton commented Jul 21, 2022

Some contract names (such as Enum.sol in gnosis) are rust reserve words that cause invalid bindings to be generated.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@clifton
Copy link
Contributor Author

clifton commented Jul 21, 2022

re #989

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch, smol q, otherwise lgtm

ethers-contract/ethers-contract-abigen/src/util.rs Outdated Show resolved Hide resolved
@clifton
Copy link
Contributor Author

clifton commented Jul 21, 2022

ok @mattsse i made that change and fixed it up. should be good to go.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gakonst gakonst merged commit aa00872 into gakonst:master Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants