Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(abigen): safe ident field names #989

Merged
merged 1 commit into from
Mar 5, 2022
Merged

fix(abigen): safe ident field names #989

merged 1 commit into from
Mar 5, 2022

Conversation

oblique
Copy link
Contributor

@oblique oblique commented Mar 5, 2022 •
edited
Loading

Motivation

I was generating bindings for a contract that imports dYdX's I_Solo.sol and got an error because AssetAmount has a field that is called ref.

Solution

ref is a reserved word, so I use util::safe_ident instead of util::ident for field names.

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@gakonst gakonst merged commit 46d7afd into gakonst:master Mar 5, 2022
@clifton clifton mentioned this pull request Jul 21, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oblique @gakonst