fix(contract): allow 16 calls in multicall #1934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gakonst
approved these changes
Dec 15, 2022
| @@ -608,7 +608,7 @@ impl<M: Middleware> Multicall<M> { | |||
| /// # } | |||
| /// ``` | |||
| pub async fn call<D: Detokenize>(&self) -> Result<D, M> { | |||
| assert!(self.calls.len() < 16, "Cannot decode more than 16 calls"); | |||
| assert!(self.calls.len() <= 16, "Cannot decode more than 16 calls"); | |||
There was a problem hiding this comment.
OK this should be fine due to this line https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/abi/tokens.rs#L130 and this https://github.com/gakonst/ethers-rs/blob/master/ethers-core/src/abi/tokens.rs#L341. Would be nicer if we did this with a const generic somehow so we're not bound to any number of tokens. Even better if we had an ability to return things of unknown length.
There was a problem hiding this comment.
I have propotypes for both, will prepare another PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
PR Checklist