Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_calls and call_array for Multicall #1941

Merged
merged 1 commit into from
Dec 18, 2022
Merged

add_calls and call_array for Multicall #1941

merged 1 commit into from
Dec 18, 2022

Conversation

onsails
Copy link
Contributor

@onsails onsails commented Dec 15, 2022 •
edited
Loading

Motivation

Solution

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@onsails onsails force-pushed the master branch 2 times, most recently from 6a73cb0 to fb29ad5 Compare December 15, 2022 17:51
@onsails onsails mentioned this pull request Dec 15, 2022
Merged
3 tasks
mattsse
mattsse requested changes Dec 16, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this,

some nits, also needs nightly formatting cargo +nightly fmt

ethers-contract/src/multicall/mod.rs Outdated Show resolved Hide resolved
ethers-contract/tests/it/contract.rs Outdated Show resolved Hide resolved
@onsails onsails force-pushed the master branch 3 times, most recently from 62f0afb to 725ba91 Compare December 16, 2022 12:16
gakonst
gakonst approved these changes Dec 18, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@gakonst gakonst merged commit 279aea6 into gakonst:master Dec 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse requested changes

@gakonst gakonst gakonst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@onsails @gakonst @mattsse