Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor factories to use Borrow<M> #2103

Merged
merged 3 commits into from
Feb 7, 2023
Merged

Refactor factories to use Borrow<M> #2103

merged 3 commits into from
Feb 7, 2023

Conversation

prestwich
Copy link
Collaborator

@prestwich prestwich commented Feb 1, 2023 •
edited
Loading

Depends on #2082

Motivation

  • Continue refactoring types that take Arc<M> to take B: Borrow<M> instead.
  • Provide backwards-compatible aliases

Solution

  • Refactor ethers_contracts::factory module to be abstract over B
  • provide type aliases

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog
  • Breaking changes

@prestwich prestwich added enhancement New feature or request rust Pull requests that update Rust code labels Feb 1, 2023
@prestwich prestwich self-assigned this Feb 1, 2023
@prestwich prestwich marked this pull request as ready for review February 7, 2023 18:07
@gakonst gakonst merged commit 2607c67 into master Feb 7, 2023
@gakonst gakonst deleted the prestwich/borrow-factory branch February 7, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

Assignees

@prestwich prestwich

Labels
enhancement New feature or request rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prestwich @gakonst