Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chain): add degen chain mainnet #2778

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

guidota
Copy link
Contributor

@guidota guidota commented Apr 10, 2024

Motivation

There is no support for Degen chain.

Solution

Add Degen chain to Chain.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@guidota guidota changed the title chore(chain): add degen chain mainnet feat(chain): add degen chain mainnet Apr 10, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need spec update, see failing test

@guidota
Copy link
Contributor Author

guidota commented Apr 10, 2024

Thank you for the feedback on my pull request. I'm a bit confused about the request to update the spec. The failing tests I see appear to be related to rate limiting (daily request count exceeded, request rate limited) rather than the changes I made. I've reviewed the code and don't see any issues with the functionality I've updated.

Could you please provide more context on which specific part of the spec you would like me to update? I want to make sure I address the right issue. Additionally, I've checked the clippy errors, and they don't seem directly related to the change I submitted.

Please let me know if you need any clarification or have additional information I should review. I'm happy to make any necessary updates to ensure my pull request is ready for merging.

@mattsse
Copy link
Collaborator

mattsse commented Apr 10, 2024

ah sorry, could you please open the pr against in this repo

https://github.com/alloy-rs/chains

@guidota
Copy link
Contributor Author

guidota commented Apr 10, 2024

Thanks for the help!
PR here alloy-rs/chains#57

@guidota
Copy link
Contributor Author

guidota commented Apr 12, 2024

Revisiting this, can it be merged here too? 🙏🏼

@guidota guidota requested a review from mattsse April 12, 2024 14:00
@gakonst gakonst merged commit 51fe937 into gakonst:master Apr 15, 2024
8 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants