Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce commutativity of ENS reverse resolution #996

Merged
merged 1 commit into from
Mar 8, 2022
Merged

Enforce commutativity of ENS reverse resolution #996

merged 1 commit into from
Mar 8, 2022

Conversation

sbihel
Copy link
Contributor

@sbihel sbihel commented Mar 8, 2022 •
edited
Loading

As specified in https://docs.ens.domains/dapp-developer-guide/resolving-names#reverse-resolution

PR Checklist

  • Added Tests
    • I'm not sure where to find a negative test.
  • Added Documentation
  • Updated the changelog

mattsse
mattsse approved these changes Mar 8, 2022
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

gakonst
gakonst approved these changes Mar 8, 2022
View reviewed changes
Copy link
Owner

@gakonst gakonst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I Guess this adds an extra RPC Call, but not much we can do about it. Massive footgun otherwise. LGTM

@gakonst gakonst merged commit 1641be7 into gakonst:master Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gakonst gakonst gakonst approved these changes

@mattsse mattsse mattsse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbihel @gakonst @mattsse