Add sunSource #1823
Merged
Add sunSource #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.2 #1823 +/- ##
===========================================
+ Coverage 65.09% 66.83% +1.73%
===========================================
Files 473 472 -1
Lines 23750 23801 +51
Branches 3368 3396 +28
===========================================
+ Hits 15461 15908 +447
+ Misses 7094 6699 -395
+ Partials 1195 1194 -1
☔ View full report in Codecov by Sentry. |
GuoLei1990
reviewed
Nov 1, 2023
packages/core/src/Scene.ts
Outdated
| return this._shadowSource; | ||
| } | ||
|
|
||
| set shadowSource(light: DirectLight | null) { |
There was a problem hiding this comment.
Don't need this, just sunSource or sunLight is enough! Every light can have shadow in the future
GuoLei1990
reviewed
Nov 1, 2023
packages/core/src/Scene.ts
Outdated
| return this._sunSource; | ||
| } | ||
|
|
||
| set sunSource(light: DirectLight | null) { |
GuoLei1990
requested changes
Nov 1, 2023
packages/core/src/Scene.ts
Outdated
| @@ -76,6 +78,9 @@ export class Scene extends EngineObject { | |||
| private _fogDensity: number = 0.01; | |||
| private _fogParams: Vector4 = new Vector4(); | |||
| private _isActive: boolean = true; | |||
| private _sunSource: DirectLight | null; | |||
| private _shadowSource: DirectLight | null; | |||
| private _defaultSunlightDirection = new Vector3(0, 0, 0); | |||
GuoLei1990
reviewed
Nov 1, 2023
packages/core/src/Scene.ts
Outdated
| } else { | ||
| this._sunLight = null; | ||
| shaderData.setVector3(Scene._sunlightDirectionProperty, this._defaultSunlightDirection); |
GuoLei1990
reviewed
Nov 1, 2023
packages/core/src/Scene.ts
Outdated
| @@ -63,7 +63,7 @@ export class Scene extends EngineObject { | |||
| /** @internal */ | |||
| _rootEntities: Entity[] = []; | |||
| /** @internal */ | |||
| _sunLight: Light; | |||
| _sunlight: DirectLight | null; | |||
There was a problem hiding this comment.
I think this move to LightManager is better
GuoLei1990
approved these changes
Nov 1, 2023
This was
linked to
issues
Nov 1, 2023
Closed
zhuxudong
added a commit
to zhuxudong/engine
that referenced
this pull request
Nov 7, 2023
* dev/1.2: (31 commits) Add sunSource (galacean#1823) Fix(ShaderLab): make `UsePass` directive compatible with all builtin shader names (galacean#1855) feat: ParticleGenerator support simulationSpeed (galacean#1854) fix: sprite destroy (galacean#1852) "v1.1.0-beta.18" Fix quaternion to euler bug (galacean#1851) Fix ColorOverLifetimeModule mode invalid bug (galacean#1850) fix: no autoplay when set animatorController after enable (galacean#1843) Refactor `glTFResource` (galacean#1831) Fix material destoroy bug (galacean#1847) Fix Sprite can't batch bug caused by material instance (galacean#1830) "v1.1.0-beta.17" fix: glTF animation parse bug (galacean#1845) fix: mesh decoder (galacean#1844) "v1.1.0-beta.16" Fix blendShape crossFade bug (galacean#1841) fix: ignore ambient in 2d template (galacean#1836) "v1.1.0-beta.15" Fix blendShapeAnimation crossFade bug (galacean#1840) fix: ignore case of asset url (galacean#1809) ... # Conflicts: # packages/loader/src/gltf/parser/GLTFParserContext.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
support #1814 and fix #1810
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information: