Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ktx2 texture support #1829

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Fix ktx2 texture support #1829

merged 1 commit into from
Oct 26, 2023

Conversation

gz65555
Copy link
Collaborator

@gz65555 gz65555 commented Oct 23, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (25d010d) 64.99% compared to head (0dc90b6) 65.07%.

❗ Current head 0dc90b6 differs from pull request most recent head 232f5c2. Consider uploading reports for the commit 232f5c2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1829      +/-   ##
==========================================
+ Coverage   64.99%   65.07%   +0.08%     
==========================================
  Files         473      473              
  Lines       23749    23753       +4     
  Branches     3366     3368       +2     
==========================================
+ Hits        15436    15458      +22     
+ Misses       7110     7100      -10     
+ Partials     1203     1195       -8     
Files Coverage Δ
packages/loader/src/ktx2/KTX2Loader.ts 14.13% <10.00%> (-0.65%) ⬇️

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GuoLei1990 GuoLei1990 added bug Something isn't working texture labels Oct 26, 2023
@GuoLei1990 GuoLei1990 modified the milestone: 1.2 Oct 26, 2023
@GuoLei1990 GuoLei1990 changed the title fix: ktx2 texture support Fix ktx2 texture support Oct 26, 2023
@GuoLei1990 GuoLei1990 merged commit 87cacfd into galacean:main Oct 26, 2023
5 checks passed
@GuoLei1990 GuoLei1990 mentioned this pull request Oct 26, 2023
3 tasks
GuoLei1990 added a commit that referenced this pull request Nov 1, 2023
* main: (29 commits)
  Fix(ShaderLab): make `UsePass` directive compatible with all builtin shader names (#1855)
  feat: ParticleGenerator support simulationSpeed (#1854)
  fix: sprite destroy (#1852)
  "v1.1.0-beta.18"
  Fix quaternion to euler bug (#1851)
  Fix ColorOverLifetimeModule mode invalid bug (#1850)
  fix: no autoplay when set animatorController after enable (#1843)
  Fix material destoroy bug (#1847)
  Fix Sprite can't batch bug caused by material instance (#1830)
  "v1.1.0-beta.17"
  fix: glTF animation parse bug (#1845)
  fix: mesh decoder (#1844)
  "v1.1.0-beta.16"
  Fix blendShape crossFade bug (#1841)
  fix: ignore ambient in 2d template (#1836)
  "v1.1.0-beta.15"
  Fix blendShapeAnimation crossFade bug (#1840)
  fix: ignore case of asset url (#1809)
  `Shaderlab` remove editor properties (#1825)
  fix: ktx2 texture support (#1829)
  ...

# Conflicts:
#	packages/core/src/particle/ParticleRenderer.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working texture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants