Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BlendShape by passing 0.0 avoids precision issues and optimizes performance #1890

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Fix BlendShape by passing 0.0 avoids precision issues and optimizes performance #1890

merged 2 commits into from
Dec 4, 2023

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

fix https://aone.alipay.com/v2/project/22200295/bug/101324332#

  if(i == 51 && weight == 0.0){
​        weight = 0.0; // This sentence is very important and indicates the existence of accuracy issues.
​        position.xyz += getBlendShapeVertexElement(i, vertexElementOffset) * weight;
​    }else{
​        position.xyz += getBlendShapeVertexElement(i, vertexElementOffset) * weight;
​    }

@zhuxudong zhuxudong added bug Something isn't working enhancement New feature or request labels Nov 30, 2023
@zhuxudong zhuxudong self-assigned this Nov 30, 2023
@GuoLei1990 GuoLei1990 changed the title fix: bypassing 0.0 avoids precision issues and optimizes performance Fix bypassing 0.0 avoids precision issues and optimizes performance Dec 4, 2023
@GuoLei1990 GuoLei1990 changed the title Fix bypassing 0.0 avoids precision issues and optimizes performance Fix by passing 0.0 avoids precision issues and optimizes performance Dec 4, 2023
@GuoLei1990 GuoLei1990 merged commit a35d8c2 into galacean:main Dec 4, 2023
5 checks passed
@GuoLei1990 GuoLei1990 changed the title Fix by passing 0.0 avoids precision issues and optimizes performance Fix BlendShape by passing 0.0 avoids precision issues and optimizes performance Dec 4, 2023
GuoLei1990 added a commit that referenced this pull request Dec 15, 2023
@GuoLei1990
Merge branch 'main' into dev/1.2
7041707 
* main:
  SceneLoader add shadow cascade splits parser (#1899)
  "v1.1.0-beta.27"
  "v1.1.0-beta.26"
  refactor: complement texture loader params (#1898)
  ci: upgrade husky version (#1900)
  "v1.1.0-beta.25"
  Shaderlab detect shader with duplicate name (#1897)
  `ParticleGradient` support  `colorKeys` and `alphaKeys` modification (#1894)
  Fix by passing 0.0 avoids precision issues and optimizes performance (#1890)
  Adds protection for value infinity in `BoundingBox` (#1892)

# Conflicts:
#	package.json
@zhuxudong zhuxudong mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuoLei1990 GuoLei1990 GuoLei1990 requested changes

Assignees

@zhuxudong zhuxudong

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zhuxudong @GuoLei1990