Shaderlab detect shader with duplicate name #1897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuoLei1990
approved these changes
Dec 8, 2023
GuoLei1990
added a commit
that referenced
this pull request
Dec 15, 2023
* main: SceneLoader add shadow cascade splits parser (#1899) "v1.1.0-beta.27" "v1.1.0-beta.26" refactor: complement texture loader params (#1898) ci: upgrade husky version (#1900) "v1.1.0-beta.25" Shaderlab detect shader with duplicate name (#1897) `ParticleGradient` support `colorKeys` and `alphaKeys` modification (#1894) Fix by passing 0.0 avoids precision issues and optimizes performance (#1890) Adds protection for value infinity in `BoundingBox` (#1892) # Conflicts: # package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Shaderlab detect shader with duplicate name
What is the current behavior? (You can also link to an open issue here)
Shaders with same name can compiled successfully
What is the new behavior (if this is a feature change)?
An error will be thrown when compiling a shader with the same name
close #1896