Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleGradient support colorKeys and alphaKeys modification #1894

Merged
merged 8 commits into from
Dec 7, 2023

Conversation

JujieX
Copy link
Contributor

@JujieX JujieX commented Dec 5, 2023

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

fix: #1893

@JujieX JujieX added the bug Something isn't working label Dec 5, 2023
@JujieX JujieX added this to the 1.2 milestone Dec 5, 2023
Copy link
Member

@GuoLei1990 GuoLei1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unit test

@GuoLei1990 GuoLei1990 changed the title Feat: add onValueChanged for ColorKey and AlphaKey ParticleGradient support modify colorKeys and alphaKeys Dec 7, 2023
@GuoLei1990 GuoLei1990 added enhancement New feature or request particle and removed bug Something isn't working labels Dec 7, 2023
@GuoLei1990 GuoLei1990 changed the title ParticleGradient support modify colorKeys and alphaKeys ParticleGradient support colorKeys and alphaKeys modification Dec 7, 2023
@GuoLei1990 GuoLei1990 merged commit 18a384f into galacean:main Dec 7, 2023
5 checks passed
GuoLei1990 added a commit that referenced this pull request Dec 15, 2023
* main:
  SceneLoader add shadow cascade splits parser (#1899)
  "v1.1.0-beta.27"
  "v1.1.0-beta.26"
  refactor: complement texture loader params (#1898)
  ci: upgrade husky version (#1900)
  "v1.1.0-beta.25"
  Shaderlab detect shader with duplicate name (#1897)
  `ParticleGradient` support  `colorKeys` and `alphaKeys` modification (#1894)
  Fix by passing 0.0 avoids precision issues and optimizes performance (#1890)
  Adds protection for value infinity in `BoundingBox` (#1892)

# Conflicts:
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request particle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

color couldn't be modified real-time in ParticleRender's colorOverLifeModule
2 participants