Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-links between trees #7

Closed
abensonca opened this issue Feb 18, 2016 · 2 comments
Closed

Cross-links between trees #7

abensonca opened this issue Feb 18, 2016 · 2 comments
Labels
enhancement New feature or request minor

Comments

@abensonca
Copy link
Collaborator

Original report by Io Odderskov (Bitbucket: ioodderskov, GitHub: ioodderskov).


Hi,

I am running Galacticus on N-body merger trees constructed with the code Consistent Trees. When the trees are constructed with this code, hosts and their subhalos can apparently belong to different trees. This causes an error in Galacticus:

Fatal error in Build_Descendent_Pointers():
failed to find host node: 42283 of 42279

I thought I might solve the problem by changing the argument in this call (in merger_trees.file_maker.simple.F90):

 call mergerTrees%setSelfContained(.true.) 

from ".true." to ".false.". However, when I do this, I get the error:

Fatal error in Merger_Tree_Read_Initialize():
only self-contained trees are supported

Is this indeed the case, (or can this be due to a conflict with some other parameter or setting, for example)? If so, do you have any suggestions for how to solve the problem? For now, I have created a small script that goes through the tree and changes the tree indices such that hosts and subhalos have the same tree index. However, this is rather time-consuming for large trees.

@abensonca
Copy link
Collaborator Author

Original comment by Andrew Benson (Bitbucket: abensonca, GitHub: abensonca).


In these cases you have two options. The correct thing to do is to take all interconnected trees - referred to as a "forest" in Rockstar/ConsistentTrees - and include all halos from these trees as a single forest in the merger tree file that you construct for Galacticus. ConsistentTrees outputs forest information which allows you to do this. Galacticus will then correctly handle these cases.

The alternative, incorrect, thing to do is to set

<mergerTreeReadMissingHostsAreFatal value="false"/>

which tells Galacticus to ignore missing hosts. This will allow you to run the trees through Galacticus, but the results you get will not be consistent with the true behavior of the N-body simulation.

@abensonca
Copy link
Collaborator Author

Original comment by Io Odderskov (Bitbucket: ioodderskov, GitHub: ioodderskov).


Thank you!

@abensonca abensonca added minor enhancement New feature or request labels Aug 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request minor
Projects
None yet
Development

No branches or pull requests

1 participant