Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first version of hirondelle crim ogc api processes #114

Merged

Conversation

MarkusKonk
Copy link
Contributor

Similar to the zoo project tool, this tool contains a collection of wrapped ogc api processes.

<param name="aoi" label="aoi" optional="false" value="" help="No description provided!" type="data" format="txt"/>
<param name="collection" label="collection" optional="false" value="" help="No description provided!" type="text"/>
<param name="cloud_cover_Array_float" label="cloud_cover" optional="false" value="" help="Please provide comma-seperated values of type float here." type="text"/>
<param name="s3_access_key" label="s3_access_key" optional="false" value="" help="Access key to Copernicus data provider. See https://documentation.dataspace.copernicus.eu/Registration.html and https://documentation.dataspace.copernicus.eu/APIs/S3.html#generate-secrets for details." type="text"/>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should not do that ... never safe credentials as tool parameters, those are captured forever for reproducibility and leak everywhere when you are assets.

Galaxy 24.1 that we will deploy this month, I hope, will have "Bring Your Own Storage", this will enable you to mount in all kind of S3 buckets into your workspace.

@MarkusKonk
Copy link
Contributor Author

I don't understand why the test fails. As you can see in the summary, the standard error does contain the text I am looking for: HTTP 401 Unauthorized

@bgruening
Copy link
Collaborator

image

@bgruening
Copy link
Collaborator

You are looking in stderr for text, but you are not saying that the test is actually expected to fail. See https://docs.galaxyproject.org/en/latest/dev/schema.html#id99

<when value="download-band-sentinel2-stac-item">
<param name="cookie" label="cookie" optional="false" value="" type="text"/>
<param name="product_url" label="product_url" optional="false" value="" help="No description provided!" type="text"/>
<param name="band" label="band" optional="false" value="" help="No description provided!" type="select">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No description provided?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, this is confusing. I will remove it.

@bgruening bgruening merged commit 89c1889 into galaxyecology:master Jun 7, 2024
11 checks passed
@bgruening bgruening deleted the hirondelle_crim_ogc_api_processes branch June 7, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants