-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HTCondor support #65
Conversation
…ronment variables
@jmchilton @mvdbeek I think this PR has nice things in it that can be used even if the Galaxy PR was not merged and it should not break anything else. Could I get a review? Thanks! |
</plugin> | ||
{% endif %} | ||
</plugins> | ||
<handlers default="handlers"> | ||
<!-- The default handler can be changed by specifying the GALAXY_HANDLERS_DEFAULT environment variable. --> | ||
<handlers default_from_environ="GALAXY_HANDLERS_DEFAULT" default="handlers"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet working as we depend on the Galaxy patch: galaxyproject/galaxy#2278
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
but it should still work as is, just that you can't use the GALAXY_HANDLERS_DEFAULT env var, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jupp. Galaxy will just ignore this attribute.
@bgruening Yep, looks nice, but I haven't tested the HTCondor part. If you can just think of something for replacing the |
Okay, this is very nice, 👍 |
Thanks a lot @bgruening |
Awesome! Thanks for the merge! |
In addition this PR introduces a macro file.
The PR is completely untested. Early feedback welcome.
Depends on galaxyproject/galaxy#2278