Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTCondor support #65

Merged
merged 11 commits into from
May 13, 2016
Merged

Add HTCondor support #65

merged 11 commits into from
May 13, 2016

Conversation

bgruening
Copy link
Member

@bgruening bgruening commented May 1, 2016

In addition this PR introduces a macro file.

The PR is completely untested. Early feedback welcome.

Depends on galaxyproject/galaxy#2278

@bgruening bgruening added the WIP label May 1, 2016
@bgruening bgruening removed the WIP label May 13, 2016
@bgruening
Copy link
Member Author

@jmchilton @mvdbeek I think this PR has nice things in it that can be used even if the Galaxy PR was not merged and it should not break anything else.

Could I get a review? Thanks!

</plugin>
{% endif %}
</plugins>
<handlers default="handlers">
<!-- The default handler can be changed by specifying the GALAXY_HANDLERS_DEFAULT environment variable. -->
<handlers default_from_environ="GALAXY_HANDLERS_DEFAULT" default="handlers">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet working as we depend on the Galaxy patch: galaxyproject/galaxy#2278

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but it should still work as is, just that you can't use the GALAXY_HANDLERS_DEFAULT env var, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jupp. Galaxy will just ignore this attribute.

@mvdbeek
Copy link
Member

mvdbeek commented May 13, 2016

@bgruening Yep, looks nice, but I haven't tested the HTCondor part. If you can just think of something for replacing the default="slurm_cluster"> you got the 👍

@mvdbeek
Copy link
Member

mvdbeek commented May 13, 2016

Okay, this is very nice, 👍

@mvdbeek mvdbeek merged commit a76f657 into galaxyproject:master May 13, 2016
@mvdbeek
Copy link
Member

mvdbeek commented May 13, 2016

Thanks a lot @bgruening

@bgruening
Copy link
Member Author

Awesome! Thanks for the merge!

@mvdbeek mvdbeek changed the title WIP: add HTCondor support Add HTCondor support May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants