Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a subdirectory for user pages? #36

Closed
tnabtaf opened this issue Dec 6, 2016 · 21 comments
Closed

Create a subdirectory for user pages? #36

tnabtaf opened this issue Dec 6, 2016 · 21 comments
Assignees

Comments

@tnabtaf
Copy link
Collaborator

tnabtaf commented Dec 6, 2016

Hi All,

MoinMoin user pages were translated directly to the new site, meaning that they all exist at the top level of the /src directory. I'd like to propose that we create a separate directory for user pages, move them all there, and then update any links in the site to go to the new pages. This can all be done programmatically.

We could also change the page naming convention while we are at it. It is currently FirstLast.

Open Questions:

1. What do people think of the proposal?

2. Where should they moved to if we move them?

A couple of ideas come to mind:

/src/People/
/src/Community/
/src/Community/People/

3. Should we change the naming convention?

@dannon
Copy link
Member

dannon commented Dec 6, 2016

+1 to pushing it into /People/, or /Community/People/, though perhaps we want to standardize to lowercase, a-la #29 ?

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 6, 2016

My preferences:

1. What do people think of the proposal?

👍

2. Where should they moved to if we move them?

/src/People/ 👍

3. Should we change the naming convention?

Hmm. We could change these to be people's GItHub names. The Galaxy page would not replace their home page, but people could have one if they want a Galaxy specific page.

A specific proposal:

  1. We use the MoinMoin names by default
  2. Whoever does the translation (and I volunteer), contacts people before doing it, and asks them what they would like, suggesting github name as an option.

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 6, 2016

@dannon I've been using Caps for DirectoryNames since 1993. However, I actually have no opinion on caps vs non-caps.

@bgruening
Copy link
Member

  1. What do people think of the proposal?

👍

  1. Where should they moved to if we move them?

/community/people/ :+1:

  1. Should we change the naming convention?

lowercase

@afgane
Copy link
Contributor

afgane commented Dec 8, 2016

My preferences:

1. What do people think of the proposal?

👍

2. Where should they moved to if we move them?

/src/people/ 👍 (just because it's a little shorter but /src/community/people is fine too)

3. Should we change the naming convention?
lowercase; I'd also go for full name joined with a - (e.g., enis-afgan) vs. Github ID.

@tnabtaf tnabtaf self-assigned this Dec 17, 2016
@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 17, 2016

Going with

/src/people/

for the directory name. Waiting on decisions in #39 to figure out what the default new naming convention is for each person page. That is, should EnisAfgan become

/src/people/enis-afgan or /src/people/enis_afgan or /src/people/enisafgan?

Also planning to give people these choices

  • first_last (assuming _) - the default action if we don't get a response.
  • githubname - for example, the DaveClements page would become the /src/people/tnabtaf page.
  • Drop their page and change any in-hub links to point to an external page
  • Drop their page and change any in-hub links not to be links any more.

@afgane
Copy link
Contributor

afgane commented Dec 17, 2016 via email

@dannon
Copy link
Member

dannon commented Dec 17, 2016

Let's go with hyphenated, it's pretty much standard.

@dannon
Copy link
Member

dannon commented Dec 17, 2016

@tnabtaf I actually have outstanding work that interacts with this change a lot (in the partials branch), so I can update my script to change these across the board.

So, directories like /src/GalaxyTeam/DannonBaker/ will be /src/galaxy-team/dannon-baker/, and I'll update references across the repo.

@bgruening
Copy link
Member

@dannon shouldn't this be /src/people/galaxy-team/dannon-baker/?
I would like to see many different teams, like IUC, NLP, GalaxyP ... and imho they should be under people, or /src/teams/

@dannon
Copy link
Member

dannon commented Dec 17, 2016

@bgruening That was just an example. I'm not moving anything, just handling the renaming, then we can move stuff.

Edit (I guess technically it is a move to rename, but I mean content directory/structural move)

@dannon
Copy link
Member

dannon commented Dec 17, 2016

@bgruening Regarding teams, I'd much rather see everyone in /src/people/. If we do want to build collections of people for display, teams in particular, we should do something like

---
title: Firstname Lastname
collection: team_iuc
collection: team_galaxy
...
---

in the yaml frontmatter for the person. Then we can have them show up on team pages as appropriate, people can belong to multiple, and so on.

@bgruening
Copy link
Member

Yes!

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 17, 2016

So, we'll go with hyphens, and @dannon would prefer to do the change. Dannon I'll send the email below to everyone that has a person page and a wiki account. Can we hold off on the moving/renaming until later in the week? (I also have a script that can do this, but then we'd have merge challenges.)

Dannon, Here's the current email. I'll probably send these our within and hour from now. I'll send you python dicts with their mappings and responses by, say the end of this Wednesday.

Dear Galaxy Wiki User,

As you may be aware, we are in the process of moving the Galaxy Wiki to a new platform we are calling the Galaxy Hub. As a part of this effort, we are also moving user pages from the old wiki to the new hub.

In the wiki, user pages had to occur at the top level. In the Hub we are consolidating them in the "people" directory and shifting to all lower case for page names.

Unless we hear from you in the next few days, your user page will move from:
https://wiki.galaxyproject.org/DaveClements

to
https://new.galaxyproject.org/people/dave-clements

which will eventually become just
https://galaxyproject.org/people/dave-clements

However there are other options too:

  1. Use a different (all lower case) name. This could be your GitHub id.
  2. Drop your user page and set any links to it to point to an external page.
  3. Drop your user page and convert links to it to be plain text.

If you are interested in any of these other options, please let me know which one, and if appropriate, what the page name should be, or where any links should point.

Thanks,

Dave C

@dannon
Copy link
Member

dannon commented Dec 17, 2016

@tnabtaf I guess it could wait, but I was going to do this for everything on the site, not just people pages, in a single pass. How about we do that, and afterwards encourage people to rename if it doesn't work for them?

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 17, 2016

I think I missed your post by seconds. :-/

Emails have gone out.

I think it's fine if you just do the move. If people want another option, they will let me know and I can do that in a cleanup stage. So, go for it.

@dannon
Copy link
Member

dannon commented Dec 17, 2016

Yeah, I'm going to just do it and we can do any requested manual curation later.

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Dec 17, 2016

There are 44 person pages. I have a python dict with the mapping in it, do you want it?

@dannon
Copy link
Member

dannon commented Dec 17, 2016

I don't think so, since I'm applying this change to the entire site. (people are irrelevant ;) )

@tnabtaf
Copy link
Collaborator Author

tnabtaf commented Feb 15, 2017

Moved all person pages from top level directory to the new people subdirectory. See the commit

@tnabtaf tnabtaf closed this as completed Feb 15, 2017
@dannon
Copy link
Member

dannon commented Feb 15, 2017

@tnabtaf Thanks for following up on this, I forgot to roll it into the hyphen mass-move, good catch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants