Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some links into the top menu #29

Merged
merged 1 commit into from
Dec 6, 2016

Conversation

bebatut
Copy link
Member

@bebatut bebatut commented Dec 6, 2016

Hi,

I fixed some broken links in the top menu.

Btw, I have a question. Is it normal that some subdirectories start with a lower case letter and other with a upper case letter?

Bérénice

@bebatut
Copy link
Member Author

bebatut commented Dec 6, 2016

I just see that src directories (events, news and support) are used a lot of times in the pages with the first letter in upper case. Maybe is it better to change the subdirectories for upper case first letter than changing all the links. What do you think? In this case, this PR does not have any more sense

@dannon
Copy link
Member

dannon commented Dec 6, 2016

@bebatut Thanks! Personally I'd like to standardize towards lowercase, let's see what other folks think though. @clements?

@bebatut
Copy link
Member Author

bebatut commented Dec 6, 2016

@dannon I could help on that :)
I tried also to fix the issue with the images but I can not fix it now (at least locally). I will try again later when I will read a bit about Metalsmith and how is it working.

@dannon
Copy link
Member

dannon commented Dec 6, 2016

Merging this for now to make things functional. We should revisit standardization of directory casing, and I've made an issue for follow up at #39.

@dannon dannon merged commit 2b03d38 into galaxyproject:master Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants