Skip to content

Commit

Permalink
Fix list collection creator dragdrop event bindings.
Browse files Browse the repository at this point in the history
  • Loading branch information
dannon committed Oct 30, 2017
1 parent aacdf8d commit 1ccb404
Show file tree
Hide file tree
Showing 6 changed files with 21 additions and 10 deletions.
19 changes: 15 additions & 4 deletions client/galaxy/scripts/mvc/collection/list-collection-creator.js
Expand Up @@ -40,10 +40,23 @@ TODO:
},

render: function() {
this.$el
this.dragStartHandler = _.bind(this._dragstart, this);
this.dragEndHandler = _.bind(this._dragend, this);
var handle = this.$el
.attr("data-element-id", this.element.id)
.attr("draggable", true)
.html(this.template({ element: this.element }));
.html(this.template({ element: this.element }))
.get(0);
handle.addEventListener(
"dragstart",
this.dragStartHandler,
false
);
handle.addEventListener(
"dragend",
this.dragEndHandler,
false
);
if (this.selected) {
this.$el.addClass("selected");
}
Expand Down Expand Up @@ -102,8 +115,6 @@ TODO:
"click .name": "_clickName",
"click .discard": "_clickDiscard",

dragstart: "_dragstart",
dragend: "_dragend",
dragover: "_sendToParent",
drop: "_sendToParent"
},
Expand Down
2 changes: 1 addition & 1 deletion static/maps/mvc/collection/list-collection-creator.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions static/scripts/bundled/analysis.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/analysis.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/libs.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/mvc/collection/list-collection-creator.js

Large diffs are not rendered by default.

0 comments on commit 1ccb404

Please sign in to comment.