Do not rely on the existence of the analysis app router

galaxyproject · Oct 9, 2017 · 220fdcc · 220fdcc
1 parent dcad663
commit 220fdcc
Show file tree

Hide file tree

Showing 6 changed files with 18 additions and 12 deletions.
diff --git a/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js b/client/galaxy/scripts/mvc/dataset/dataset-li-edit.js
@@ -64,8 +64,10 @@ var DatasetListItemEdit = _super.extend(
                 faIcon      : 'fa-pencil',
                 classes     : 'edit-btn',
                 onclick     : function( ev ) {
-                    ev.preventDefault();
-                    Galaxy.router.push( 'datasets/edit', { dataset_id : self.model.attributes.id } );
+                    if ( Galaxy.router ) {
+                        ev.preventDefault();
+                        Galaxy.router.push( 'datasets/edit', { dataset_id : self.model.attributes.id } );
+                    }
                 }
             };
         // disable if purged or deleted and explain why in the tooltip
@@ -206,8 +208,10 @@ var DatasetListItemEdit = _super.extend(
             classes     : 'report-error-btn',
             faIcon      : 'fa-bug',
             onclick     : function( ev ) {
-                ev.preventDefault();
-                Galaxy.router.push( 'datasets/error', { dataset_id : self.model.attributes.id } );
+                if ( Galaxy.router ) {
+                    ev.preventDefault();
+                    Galaxy.router.push( 'datasets/error', { dataset_id : self.model.attributes.id } );
+                }
             }
         });
     },
@@ -223,8 +227,10 @@ var DatasetListItemEdit = _super.extend(
                 target      : this.linkTarget,
                 faIcon      : 'fa-refresh',
                 onclick     : function( ev ) {
-                    ev.preventDefault();
-                    Galaxy.router.push( '/', { job_id : creating_job } );
+                    if ( Galaxy.router ) {
+                        ev.preventDefault();
+                        Galaxy.router.push( '/', { job_id : creating_job } );
+                    }
                 }
             });
         }

diff --git a/static/maps/mvc/dataset/dataset-li-edit.js.map b/static/maps/mvc/dataset/dataset-li-edit.js.map
diff --git a/static/scripts/bundled/analysis.bundled.js b/static/scripts/bundled/analysis.bundled.js
diff --git a/static/scripts/bundled/analysis.bundled.js.map b/static/scripts/bundled/analysis.bundled.js.map
diff --git a/static/scripts/bundled/libs.bundled.js.map b/static/scripts/bundled/libs.bundled.js.map