Fix error with validated configs

galaxyproject · Feb 2, 2018 · 2628e5f · 2628e5f
1 parent 8f3eb41
commit 2628e5f
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/galaxy/jobs/dynamic_tool_destination.py b/lib/galaxy/jobs/dynamic_tool_destination.py
@@ -377,7 +377,7 @@ def __validate_destination(cls, valid_rule, return_bool, rule, tool, counter):
         @return: validated rule and result of validation
         """
 
-        valid_destinations = get_valid_destinations_from_config()
+        valid_destinations = get_valid_destinations_from_config() ###TODO: find a place that I can declare this only once
 
         if "fail_message" in rule:
             if "destination" not in rule or rule['destination'] != "fail":
@@ -808,7 +808,7 @@ def infinite_defaultdict():
 
                             if obj['default_destination']['priority'][priority] in valid_destinations:
                                 new_config['default_destination']['priority'][priority] = obj[
-                                    'default_destination']['priority'][priority]
+                                        'default_destination']['priority'][priority]
                             else:
                                 error = ("destination '" +
                                          obj['default_destination']['priority'][priority] +