Merge pull request #2962 from guerler/fix_library_optional_flag

[16.07] Fix optional flag for library datasets in legacy library ui
galaxyproject · Sep 24, 2016 · 26d381c · 26d381c
2 parents 092a730 + aa2e783
commit 26d381c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/lib/galaxy/webapps/galaxy/controllers/library_common.py b/lib/galaxy/webapps/galaxy/controllers/library_common.py
@@ -521,8 +521,8 @@ def __ok_to_edit_metadata( ldda_id ):
                         if spec.get("readonly"):
                             continue
                         optional = kwd.get( "is_" + name, None )
-                        if optional and optional == 'true':
-                            # optional element... == 'true' actually means it is NOT checked (and therefore ommitted)
+                        if optional and optional == '__NOTHING__':
+                            # optional element... == '__NOTHING__' actually means it is NOT checked (and therefore ommitted)
                             setattr( ldda.metadata, name, None )
                         else:
                             setattr( ldda.metadata, name, spec.unwrap( kwd.get( name, None ) ) )