Remove additional div layer

galaxyproject · Jul 10, 2017 · 2908a8e · 2908a8e
1 parent 02884fa
commit 2908a8e
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 8 deletions.
diff --git a/client/galaxy/scripts/viz/visualization.js b/client/galaxy/scripts/viz/visualization.js
@@ -38,17 +38,15 @@ var CustomToJSON = {
 var select_datasets = function(dataset_url, add_track_async_url, filters, success_fn) {
 
     // history dataset selection tab
-    var $history_grid = $( '<div/>' );
     var history_grid = new GridView( {
         url_base    : Galaxy.root + 'visualization/list_history_datasets',
         url_data    : filters,
         dict_format : true,
         embedded    : true
     });
-    $history_grid.empty().append( history_grid.$el );
     var history_list = new Ui.Select.View({
-        onchange: function( history_id ) {
-            history_grid.grid.add_filter( 'history', history_id  );
+        onchange: function() {
+            history_grid.grid.add_filter( 'history', history_list.value()  );
             history_grid.update_grid();
         }
     });
@@ -60,6 +58,7 @@ var select_datasets = function(dataset_url, add_track_async_url, filters, succes
                 options.push({ label: history.name, value: history.id });
             });
             history_list.update( options );
+            history_list.trigger( 'change' );
         }
     });
 
@@ -73,7 +72,7 @@ var select_datasets = function(dataset_url, add_track_async_url, filters, succes
                 $el     : $( '<div/>' ).append( $( '<h5/>' ).append( 'Selected history:' ) )
                                        .append( history_list.$el )
                                        .append( $( '<h5/>' ).append( 'Available datasets:' ) )
-                                       .append( $history_grid )
+                                       .append( history_grid.$el )
     });
     tabs.add({  id      : 'libraries',
                 title   : 'Libraries',

diff --git a/lib/galaxy/webapps/galaxy/controllers/visualization.py b/lib/galaxy/webapps/galaxy/controllers/visualization.py
@@ -203,7 +203,6 @@ class VisualizationController( BaseUIController, SharableMixin, UsesVisualizatio
                                UsesAnnotations, UsesItemRatings ):
     _user_list_grid = VisualizationListGrid()
     _published_list_grid = VisualizationAllPublishedGrid()
-    _libraries_grid = LibrarySelectionGrid()
     _history_datasets_grid = HistoryDatasetsSelectionGrid()
     _tracks_grid = TracksterSelectionGrid()
 

diff --git a/static/maps/viz/visualization.js.map b/static/maps/viz/visualization.js.map