Selenium - bug fix for checking workflow names on workflow index page.

xref https://jenkins.galaxyproject.org/job/selenium/654/artifact/654-test-errors/test_rename2017092708331506515637/
galaxyproject · Sep 29, 2017 · 2e3c6e8 · 2e3c6e8
1 parent e132521
commit 2e3c6e8
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/test/galaxy_selenium/navigates_galaxy.py b/test/galaxy_selenium/navigates_galaxy.py
@@ -550,6 +550,13 @@ def workflow_index_rename(self, new_name, workflow_index=0):
         alert.send_keys(new_name)
         alert.accept()
 
+    @retry_during_transitions
+    def workflow_index_name(self, workflow_index=0):
+        """Get workflow name for workflow_index'th row."""
+        row_element = self.workflow_index_table_row(workflow_index=workflow_index)
+        workflow_button = row_element.find_element_by_css_selector(".menubutton")
+        return workflow_button.text
+
     def workflow_index_click_option(self, option_title, workflow_index=0):
 
         @retry_during_transitions

diff --git a/test/selenium_tests/test_workflow_management.py b/test/selenium_tests/test_workflow_management.py
@@ -38,9 +38,8 @@ def test_rename(self):
 
         @retry_assertion_during_transitions
         def check_name():
-            row_element = self.workflow_index_table_row()
-            renamed_workflow_button = row_element.find_element_by_css_selector(".menubutton")
-            assert 'CoolNewName' in renamed_workflow_button.text, renamed_workflow_button.text
+            name = self.workflow_index_name()
+            assert 'CoolNewName' == name, name
 
         check_name()