Remove redirects for repository revision installation

galaxyproject · Oct 16, 2017 · 3f5b3f1 · 3f5b3f1
1 parent 8f2db7f
commit 3f5b3f1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 8 deletions.
diff --git a/lib/galaxy/webapps/galaxy/controllers/admin_toolshed.py b/lib/galaxy/webapps/galaxy/controllers/admin_toolshed.py
@@ -475,15 +475,9 @@ def install_latest_repository_revision(self, trans, **kwd):
                         url = util.build_url(tool_shed_url, pathspec=pathspec, params=params)
                         return trans.response.send_redirect(url)
             else:
-                message = 'Cannot locate installed tool shed repository with encoded id <b>%s</b>.' % str(repository_id)
-                status = 'error'
+                return trans.show_error_message('Cannot locate installed tool shed repository with encoded id <b>%s</b>.' % str(repository_id))
         else:
-            message = 'The request parameters did not include the required encoded <b>id</b> of installed repository.'
-            status = 'error'
-        return trans.response.send_redirect(web.url_for(controller='admin',
-                                                        action='repositories',
-                                                        message=message,
-                                                        status=status))
+            return trans.show_error_message('The request parameters did not include the required encoded <b>id</b> of installed repository.')
 
     @web.expose
     @web.require_admin

diff --git a/lib/tool_shed/galaxy_install/grids/admin_toolshed_grids.py b/lib/tool_shed/galaxy_install/grids/admin_toolshed_grids.py
@@ -174,6 +174,7 @@ def get_accepted_filters(self):
                   grids.GridOperation(label="Install latest revision",
                                       condition=(lambda item: item.upgrade_available),
                                       allow_multiple=False,
+                                      target="center",
                                       url_args=dict(controller='admin_toolshed',
                                                     action='install_latest_repository_revision')),
                   grids.GridOperation(label="Install",