Skip to content

Commit

Permalink
Fix docker command_list
Browse files Browse the repository at this point in the history
command_list always generates ***docker docker***
Without fix , docker runs new image which doesn't exist ,
docker fetch it in ***docker run*** command and it generates progress information to stderr.
It will end galaxy job as fail.

But rerun same job, it will be success , because of the image is already exists , fetch process never happens.
  • Loading branch information
manabuishii authored and jmchilton committed Aug 8, 2016
1 parent 82430c0 commit 64a5572
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion lib/galaxy/tools/deps/docker_util.py
Original file line number Diff line number Diff line change
Expand Up @@ -185,7 +185,8 @@ def build_docker_run_command(
def command_list(command, command_args=[], **kwds):
"""Return Docker command as an argv list."""
command_parts = _docker_prefix(**kwds)
command_parts.extend(command_parts)
command_parts.append(command)
command_parts.extend(command_args)
return command_parts


Expand Down

0 comments on commit 64a5572

Please sign in to comment.