remove unncessary if statements

galaxyproject · Feb 20, 2016 · 6653bcb · 6653bcb
1 parent 8ee38f6
commit 6653bcb
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/lib/galaxy/model/__init__.py b/lib/galaxy/model/__init__.py
@@ -113,18 +113,13 @@ def _init_metrics( self ):
         self.numeric_metrics = []
 
     def add_metric( self, plugin, metric_name, metric_value ):
-        if isinstance( plugin, string_types ):
-            plugin = unicodify( plugin, 'utf-8' )
-
-        if isinstance( metric_name, string_types ):
-            metric_name = unicodify( metric_name, 'utf-8' )
-
+        plugin = unicodify( plugin, 'utf-8' )
+        metric_name = unicodify( metric_name, 'utf-8' )
         if isinstance( metric_value, numbers.Number ):
             metric = self._numeric_metric( plugin, metric_name, metric_value )
             self.numeric_metrics.append( metric )
         else:
-            if isinstance( metric_value, string_types ):
-                metric_value = unicodify( metric_value, 'utf-8' )
+            metric_value = unicodify( metric_value, 'utf-8' )
             if len( metric_value ) > 1022:
                 # Truncate these values - not needed with sqlite
                 # but other backends must need it.