Skip to content

Commit

Permalink
Instead of denoting unused var from items(), just use values()
Browse files Browse the repository at this point in the history
  • Loading branch information
dannon committed Mar 13, 2018
1 parent b685b53 commit 6a7fb23
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/galaxy/tools/actions/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -609,7 +609,7 @@ def _wrapped_params(self, trans, tool, incoming, input_datasets=None):

def _get_on_text(self, inp_data):
input_names = []
for _name, data in reversed(inp_data.items()):
for data in reversed(inp_data.values()):
if getattr(data, "hid", None):
input_names.append('data %s' % data.hid)

Expand Down Expand Up @@ -793,7 +793,7 @@ def create_collection(self, output, name, **element_kwds):
if "elements" in element_kwds:
elements = element_kwds["elements"]
if hasattr(elements, "items"): # else it is ELEMENTS_UNINITIALIZED object.
for _key, value in elements.items():
for value in elements.values():
# Either a HDA (if) or a DatasetCollection (the else)
if getattr(value, "history_content_type", None) == "dataset":
assert value.history is not None
Expand Down

0 comments on commit 6a7fb23

Please sign in to comment.