Avoid settings reload on visualization refresh

galaxyproject · Feb 11, 2018 · 79fc30c · 79fc30c
1 parent 269be96
commit 79fc30c
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 1 deletion.
diff --git a/client/galaxy/scripts/mvc/visualization/chart/components/model.js b/client/galaxy/scripts/mvc/visualization/chart/components/model.js
@@ -105,9 +105,11 @@ export default Backbone.Model.extend({
             this.groups.reset();
             this.groups.add(d.groups);
             this.set("modified", false);
+            this.trigger("load");
             console.debug("model::load() - Loading chart model " + d.attributes.type + ".");
             return true;
         }
+        this.trigger("load");
         console.debug("model::load() - Visualization attributes unavailable.");
         return false;
     }

diff --git a/client/galaxy/scripts/mvc/visualization/chart/views/settings.js b/client/galaxy/scripts/mvc/visualization/chart/views/settings.js
@@ -8,7 +8,7 @@ export default Backbone.View.extend({
         var self = this;
         this.chart = app.chart;
         this.setElement("<div/>");
-        this.listenTo(this.chart, "change", function() {
+        this.listenTo(this.chart, "load", function() {
             self.render();
         });
     },

diff --git a/client/galaxy/style/less/charts.less b/client/galaxy/style/less/charts.less
@@ -20,6 +20,7 @@
         float: left;
         width: 30%;
         height: 100vh;
+        padding-bottom: 32px;
         overflow: hidden;
         display: flex;
         flex-direction: column;

diff --git a/static/style/blue/base.css b/static/style/blue/base.css