Commit
…on to being simply undefined. This corrects the logic shortcutting and prevents errors like 'Cannot read property 'min' of null'
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2507,7 +2507,7 @@ extend(Track.prototype, Drawable.prototype, { | |
var data = result.data; | ||
|
||
// Tracks may not have stat data either because there is no data or data is not yet ready. | ||
if (data !== undefined && data.min !== undefined && data.max !== undefined) { | ||
if (data && data.min !== undefined && data.max !== undefined) { | ||
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
This comment has been minimized.
Sorry, something went wrong.
martenson
Member
|
||
// Compute default minimum and maximum values | ||
var min_value = data.min, | ||
max_value = data.max; | ||
|
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Won't this create an
Uncaught ReferenceError: data is not defined
in case result.data above is undefined? Are we guaranteed to have result.data? ping @dannon