Skip to content

Commit

Permalink
Trackster app entrypoint fix.
Browse files Browse the repository at this point in the history
  • Loading branch information
dannon committed Nov 20, 2017
1 parent e81d89f commit 8d9998c
Show file tree
Hide file tree
Showing 17 changed files with 32 additions and 27 deletions.
2 changes: 1 addition & 1 deletion client/galaxy/scripts/apps/trackster.js
@@ -1,7 +1,7 @@
import Trackster from "viz/trackster";

export default function tracksterApp(options) {
new Trackster(options);
new Trackster.GalaxyApp(options);
}

window.tracksterApp = tracksterApp;
4 changes: 2 additions & 2 deletions lib/galaxy/webapps/galaxy/controllers/visualization.py
Expand Up @@ -736,7 +736,7 @@ def trackster(self, trans, **kwargs):
"""

# define app configuration
app = {'jscript' : "viz/trackster"}
app = {"jscript" : "tracksterApp"}

# get dataset to add
id = kwargs.get("id", None)
Expand Down Expand Up @@ -780,7 +780,7 @@ def trackster(self, trans, **kwargs):
}

# fill template
return trans.fill_template('galaxy.panels.mako', config={'right_panel': True, 'app': app})
return trans.fill_template('galaxy.panels.mako', config={'right_panel': True, 'app': app, 'bundle': 'trackster'})

@web.expose
def circster(self, trans, id=None, hda_ldda=None, dataset_id=None, dbkey=None):
Expand Down
2 changes: 1 addition & 1 deletion static/scripts/bundled/admin.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/admin.bundled.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions static/scripts/bundled/analysis.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/analysis.bundled.js.map

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions static/scripts/bundled/libs.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/libs.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/login.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/login.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/masthead.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/masthead.bundled.js.map

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions static/scripts/bundled/trackster.bundled.js

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions static/scripts/bundled/trackster.bundled.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/workflow.bundled.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion static/scripts/bundled/workflow.bundled.js.map

Large diffs are not rendered by default.

14 changes: 8 additions & 6 deletions templates/webapps/galaxy/galaxy.panels.mako
Expand Up @@ -77,6 +77,10 @@
'libs/require',
)}
%if self.galaxy_config.get('bundle', None):
${h.js('bundled/%s.bundled' % self.galaxy_config.get('bundle'))}
%endif
<script type="text/javascript">
// configure require
// due to our using both script tags and require, we need to access the same jq in both for plugin retention
Expand Down Expand Up @@ -123,12 +127,10 @@
// load any app configured
define( 'app', function(){
var jscript = galaxy_config.app.jscript;
if( jscript ){
require([ jscript ], function( js_lib ){
$( function(){
// load galaxy module application
var module = new js_lib.default.GalaxyApp();
});
if( galaxy_config.app.jscript && window[galaxy_config.app.jscript]){
$( function(){
// load galaxy module application
window[galaxy_config.app.jscript]();
});
} else {
console.error("'galaxy_config.app.jscript' missing.");
Expand Down

0 comments on commit 8d9998c

Please sign in to comment.