Skip to content

Commit

Permalink
Externalize selenium setup with reusable workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
mvdbeek committed Jul 26, 2023
1 parent b56d785 commit 989551d
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 1 deletion.
4 changes: 3 additions & 1 deletion .github/workflows/selenium.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true
jobs:
setup-selenium:
uses: ./.github/workflows/setup_selenium.yaml
test:
name: Test
needs: setup-selenium
runs-on: ubuntu-latest
strategy:
fail-fast: false
Expand Down Expand Up @@ -66,7 +69,6 @@ jobs:
- uses: mvdbeek/gha-yarn-cache@master
with:
yarn-lock-file: 'galaxy root/client/yarn.lock'
- uses: mvdbeek/setup-chromedriver@chromedriver_puppeteer
- name: Run tests
run: ./run_tests.sh --coverage -selenium lib/galaxy_test/selenium -- --num-shards=3 --shard-id=${{ matrix.chunk }}
working-directory: 'galaxy root'
Expand Down
8 changes: 8 additions & 0 deletions .github/workflows/setup_selenium.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
on:
workflow_call:
jobs:
setup_chromedriver:
runs-on: ubuntu-latest
steps:
- name: Install chromedriver
uses: mvdbeek/setup-chromedriver@chromedriver_puppeteer

0 comments on commit 989551d

Please sign in to comment.