Followup to exception refactoring, fixes a few issues @nsoranzo notic…

…ed with my semiautomatic refactorings.
galaxyproject · Apr 24, 2017 · 9c44ae0 · 9c44ae0
1 parent 4395792
commit 9c44ae0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/lib/galaxy/webapps/galaxy/api/lda_datasets.py b/lib/galaxy/webapps/galaxy/api/lda_datasets.py
@@ -607,7 +607,7 @@ def traverse( folder ):
                 log.exception( "Unable to create archive for download" )
                 raise exceptions.InternalServerError( "Unable to create archive for download." )
             except Exception:
-                log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[ 0 ] )
+                log.exception( "Unexpected error %s in create archive for download" )
                 raise exceptions.InternalServerError( "Unable to create archive for download." )
             composite_extensions = trans.app.datatypes_registry.get_composite_extensions()
             seen = []

diff --git a/lib/galaxy/webapps/galaxy/controllers/library_common.py b/lib/galaxy/webapps/galaxy/controllers/library_common.py
@@ -1863,7 +1863,7 @@ def __str__( self ):
                     status = 'error'
                 except:
                     error = True
-                    log.exception( "Unexpected error %s in create archive for download", sys.exc_info()[0] )
+                    log.exception( "Unexpected error %s in create archive for download" )
                     message = "Unable to create archive for download, please report - %s" % sys.exc_info()[0]
                     status = 'error'
                 if not error:

diff --git a/lib/tool_shed/galaxy_install/tools/tool_panel_manager.py b/lib/tool_shed/galaxy_install/tools/tool_panel_manager.py
@@ -90,7 +90,7 @@ def config_elems_to_xml_file( self, config_elems, config_filename, tool_path ):
             fh.write( '</toolbox>\n' )
             fh.close()
         except Exception:
-            log.exception( "Exception in ToolPanelManager.config_elems_to_xml_file: %s" )
+            log.exception( "Exception in ToolPanelManager.config_elems_to_xml_file" )
         finally:
             lock.release()
 

diff --git a/lib/tool_shed/repository_registry.py b/lib/tool_shed/repository_registry.py
@@ -345,7 +345,7 @@ def remove_entry( self, repository ):
             # The viewable repository numbers and the categorized (filtered) lists of repository tuples
             # may be slightly skewed, but that is no reason to result in a potential server error.  All
             # will be corrected at next server start.
-            log.exception( "Handled error removing entry from repository registry: %s." )
+            log.exception( "Handled error removing entry from repository registry" )
 
     @property
     def sa_session( self ):